Skip to content

[9.x] Fix Conditional::when and Conditional::unless when called with invokable#41270

Merged
nunomaduro merged 2 commits into
laravel:9.xfrom
bastien-phi:improve_again_conditionable_docblock
Feb 28, 2022
Merged

[9.x] Fix Conditional::when and Conditional::unless when called with invokable#41270
nunomaduro merged 2 commits into
laravel:9.xfrom
bastien-phi:improve_again_conditionable_docblock

Conversation

@bastien-phi

Copy link
Copy Markdown
Contributor

This PR fixes the PHPStan analysis when Conditional::when and Conditional::unless are called with invokable object

Comment thread src/Illuminate/Conditionable/Traits/Conditionable.php Outdated
Comment thread src/Illuminate/Conditionable/Traits/Conditionable.php Outdated
@nunomaduro
nunomaduro marked this pull request as draft February 28, 2022 16:03
@bastien-phi
bastien-phi marked this pull request as ready for review February 28, 2022 16:42
@nunomaduro
nunomaduro merged commit d82ae59 into laravel:9.x Feb 28, 2022
@bastien-phi
bastien-phi deleted the improve_again_conditionable_docblock branch February 28, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants