[9.x] Allow eloquent whereNot() and orWhereNot() to work on column and value#41296
Conversation
|
Ah - didn't see this until I tagged - but still probably not a big deal to merge it into 9.x since it just came out. |
|
Is |
|
@deleugpn it will use the NOT keyword to negate the condition. See the code comment in the code example in the PR description. |
|
How does this address: #41096 (comment) |
As mentioned in the MySQL documentation https://dev.mysql.com/doc/refman/8.0/en/operator-precedence.html the comparison operators have higher precedence then the NOT keyword which means we don't need to wrap This is a very simple example to demonstrate that. |
Hi,
This PR #41096 added
whereNot()andorWhereNot()to the eloquent query builder and query builder.The PR allows to apply a where not on a group of wheres but does not allow to do something like this
This PR adds that (for both whereNot() and orWhereNot() ) while it also keeps the ability to use a where not on grouped wheres as well.
It will keep the same method signature developers are used to when using
where()andorWhere()by allowing to specify and$operatorand$columnvariablesIf this PR is merged now, it will be a good thing since the Original PR was not yet tagged in any new release.