-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.x] Allow overriding transport type on Mailgun transporter #41309
[9.x] Allow overriding transport type on Mailgun transporter #41309
Conversation
a498765
to
bad9722
Compare
Thanks @jnoordsij. I still feel this change was warranted as we used the Just to be clear: you weren't using these custom headers in Laravel 8, correct? |
A PR to 'mailgun' => [
'transport' => 'mailgun',
'scheme' => 'https',
], No |
Co-authored-by: Dries Vints <dries@vints.io>
Yeah, the change itself seems logical, its just even more flexible this way I feel.
I was using them in Laravel 8, but had to rewrite the implementation in Laravel 9. I used to extend the For reference, I tried to obtain the request body before sending it in both my Laravel 8 and Laravel 9 apps, and they seem to be quite different: Laravel 8
Laravel 9
|
@jnoordsij all of that is being handled by Symfony Mailer so there's nothing we can really do there. |
Yeah I figured, hence having the option to just stick with the |
In #41255 the Mailgun transport type was changed from
api
tohttps
. This breaks my application, as I add some custom headers which were working fine with the API transporter, but are ignored on the messages.mime endpoint. This MR allows overriding the transport type you want to use for Mailgun, while leaving the default option unchanged.If wanted, I can also provide a PR to add this config key to the
laravel/laravel
repo.