[9.x] Added callable support to operatorForWhere on Collection

[eusonlito]

Added callable support to operatorForWhere.

Currently only Collection methods where and whereFirst are used without callable support.

Adding callable to operatorForWhere allow complex usages as:

$city = $cities->firstWhere(fn ($city) => $city->state->available && ($city->state->id === $stateId));

or

$state = $states->firstWhere(fn ($state) => (bool)$state->cities->firstWhere('id', $cityId));

[taylorotwell]

Hmm, what all methods does this affect?

[eusonlito]

Only where and firstWhere.

Method every has a previous parameter check when only one argument:

framework/src/Illuminate/Collections/Traits/EnumeratesValues.php

Lines 294 to 298 in 1a1c140

	public function every($key, $operator = null, $value = null)
	{
	if (func_num_args() === 1) {
	$callback = $this->valueRetriever($key);

Same as partition:

framework/src/Illuminate/Collections/Traits/EnumeratesValues.php

Lines 455 to 462 in 1a1c140

	public function partition($key, $operator = null, $value = null)
	{
	$passed = [];
	$failed = [];
	$callback = func_num_args() === 1
	? $this->valueRetriever($key)
	: $this->operatorForWhere(...func_get_args());

Same sole method on LazyCollection:

framework/src/Illuminate/Collections/LazyCollection.php

Lines 1149 to 1153 in bf9f8f7

	public function sole($key = null, $operator = null, $value = null)
	{
	$filter = func_num_args() > 1
	? $this->operatorForWhere(...func_get_args())
	: $key;

firstOrFail on LazyCollection:

framework/src/Illuminate/Collections/LazyCollection.php

Lines 1173 to 1177 in bf9f8f7

	public function firstOrFail($key = null, $operator = null, $value = null)
	{
	$filter = func_num_args() > 1
	? $this->operatorForWhere(...func_get_args())
	: $key;

And contains on LazyCollection:

framework/src/Illuminate/Collections/LazyCollection.php

Lines 215 to 218 in bf9f8f7

	public function contains($key, $operator = null, $value = null)
	{
	if (func_num_args() === 1 && $this->useAsCallable($key)) {
	$placeholder = new stdClass;

[taylorotwell]

Would it be safer to just modify where and firstWhere directly instead of this method just to be sure?

[taylorotwell]

Hmm - I guess this looks OK.

[eusonlito]

@taylorotwell I will add a new check, because is_callable can get a string (like trim) and return true.

I will send a new commit changing if (is_callable($key)) { with if ($this->useAsCallable($key)).

Also a new test will be added using a callable string.

[sebdesign]

What's the difference from the first method?

$city = $cities->first(
    fn ($city) => $city->state->available && ($city->state->id === $stateId)
);