[9.x] Add String::squish() helper - #41791
Merged
Merged
Conversation
Contributor
Author
|
Looks like that failing build may not be my fault 🤞 |
Contributor
|
You can try force-pushing your branch to re-trigger GitHub Actions and get all-green. A recent merged PR can cause |
Member
|
Can you also add it to fluent strings? |
taylorotwell
marked this pull request as draft
April 2, 2022 15:25
dwightwatson
marked this pull request as ready for review
April 2, 2022 22:42
Contributor
Author
|
Of course, added to |
|
@dwightwatson could the replacement param be passed as second argument like this: public static function squish($value, $replacement = ' ')
{
return preg_replace('/\s+/', $replacement, trim($value));
} |
chu121su12
pushed a commit
to chu121su12/framework
that referenced
this pull request
Apr 5, 2022
* Add squish helper * Additional test case * Add squish to Stringable * Fix code formatting * Make more consistent * formatting Co-authored-by: Taylor Otwell <taylor@laravel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposes a new string helper method called
squish, which is named similarly to the one in Rails. I know there's a lot of fair scrutiny given to adding new helpers but felt it was worth putting it out there in case you saw the usefulness that I do.My use-cases are both when outputting user input that had additional unnecessary whitespace, and also when creating interpolated strings that have optional values (i.e.
"A {$description} listing has been created."). In both of these instances usingsquishwould make the content appear more professional.If you do like this addition I can follow-up and add it to
Stringableas well.