[9.x] Fix ViewErrorBag for JSON session serialization#42090
Merged
taylorotwell merged 3 commits intoApr 22, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
jsonsession serialization format added in Laravel 9 (#40595) doesn't work for flashed validation errors since those are serialized from the ViewErrorBag instance.ViewErrorBagdoes not implement JsonSerializable and more importantly need to be recreated when reading the session data back.This PR intends to resolve this by storing the necessary information as an array, and rehydrating the instance after reading the session data back. This tries to implement the suggestion by Taylor here: laravel/laravel#5796 (comment)
Note that this changes nothing unless
$serialization === 'json'.Fixes #40773
Related to #41850