Skip to content

[9.x] Update schedule:list colouring output#42153

Merged
taylorotwell merged 1 commit intolaravel:9.xfrom
bert-w:patch-1
Apr 27, 2022
Merged

[9.x] Update schedule:list colouring output#42153
taylorotwell merged 1 commit intolaravel:9.xfrom
bert-w:patch-1

Conversation

@bert-w
Copy link
Contributor

@bert-w bert-w commented Apr 27, 2022

I noticed that the colouring of the parameters was slightly off for the php artisan schedule:list command. I changed the regex to mark everything yellow after the command name. Note that I am assuming that command names consist of the following syntax: [\w\-:]+, meaning: word-characters (i.e. [a-zA-Z0-9_]), dashes - and/or colon :.

Before and after:
Before & After

I guess it would be nice to highlight 3 and 60 separately but that increases the complexity for little benefit.

Improve coloring output
@taylorotwell taylorotwell merged commit 7b26f1d into laravel:9.x Apr 27, 2022
@bert-w bert-w deleted the patch-1 branch May 3, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants