[9.x] Update schedule:list colouring output#42153
Merged
taylorotwell merged 1 commit intolaravel:9.xfrom Apr 27, 2022
bert-w:patch-1
Merged
[9.x] Update schedule:list colouring output#42153taylorotwell merged 1 commit intolaravel:9.xfrom bert-w:patch-1
schedule:list colouring output#42153taylorotwell merged 1 commit intolaravel:9.xfrom
bert-w:patch-1
Conversation
Improve coloring output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the colouring of the parameters was slightly off for the
php artisan schedule:listcommand. I changed the regex to mark everything yellow after the command name. Note that I am assuming that command names consist of the following syntax:[\w\-:]+, meaning: word-characters (i.e.[a-zA-Z0-9_]), dashes-and/or colon:.Before and after:

I guess it would be nice to highlight
3and60separately but that increases the complexity for little benefit.