Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Add missing onLastPage to CursorPaginator #42299

Closed
wants to merge 1 commit into from
Closed

[8.x] Add missing onLastPage to CursorPaginator #42299

wants to merge 1 commit into from

Conversation

rodrigopedra
Copy link
Contributor

Closes #42296

As stated on issue #42296 the docs on CursorPaginator``s available methods states it has a onLastPagemethod, but the implementation of that method is missing onIlluminate\Pagination\CursorPaginator` and its parent abstract class.

This PR:

  • Adds the missing onLastPage implementation to Illuminate\Pagination\CursorPaginator
  • Adds a test case covering both onLastPage and onFirstPage

@rodrigopedra
Copy link
Contributor Author

Actually docs on 8.x does not have onLastPage under "Cursor Paginator Instance Methods"

https://laravel.com/docs/8.x/pagination#cursor-paginator-instance-methods

The missing method is only on 9.x docs:

https://laravel.com/docs/9.x/pagination#cursor-paginator-instance-methods

So I am closing this and sending to 9.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant