[9.x] Add is_string check to QueriesRelationships@requalifyWhereTables#42341
Merged
Conversation
Contributor
Author
|
ping @driesvints , @taylorotwell P.S.: EDIT: added test case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42338
This PR:
is_string()check before astr_starts_with()onQueriesRelationships@requalifyWhereTablesNotes:
QueriesRelationships@requalifyWhereTableswas added by PR [9.x] Add wherehas soft deleting scopes #42100 which tried to fix table prefixing issues when using self-referencing relationswhereColumn, or other that could reference related tablesnew stdClassas enums are not available in PHP 8. As it tests the generated SQL statement, thestdClassinstance never acutually gets bound to PDO.EDIT: added information about added test case. Please read 3rd note about it.