[8.x] Retain the original attribute value during validation of an array key with a dot for correct failure message

[chiefey]

During validation of an array key with a dot, using a integer|min:1 rule - the package will incorrectly return validation.min.string instead of the expected validation.min.numeric.

Illuminate\Validation\Validator replaces the placeholder in the attribute a bit prematurely in the addFailure function.

Code will continue to makeReplacements, getMessage, getSizeMessage, getAttributeType, hasRule, getRule

You can see down the line you are searching a with-placeholder rules array for a without-placeholder key. When the numeric search fails, it will default to string.

My fix retains that original attribute value including the placeholder to return the expected failure message

[taylorotwell]

I don't think it makes sense to keep the place-holders in place when passing the attribute name to getMessage? It then checks the custom attribute array for that attribute using the place-holders, which doesn't make sense to me.

[chiefey]

@taylorotwell ok if we are worried about the custom attributes - I will isolate this change to the getSizeMessage path inside getMessage and resubmit.

[chiefey]

With this update the custom attribute array is left as-is. Only the getSizeMessage path uses the attributeWithPlaceholders value.

In this way we prevent a call to getRule with a cleaned attribute value.