[9.x] Fix queueable notification's ID overwritten

[jay-youngn]

When the notification ID has been assigned, It should not be overwritten. Even in the queue.

The case for database notification:
I've defined a special unique ID, but it's overwritten here.

If this option is not desirable, the Str::uuid() should also be replace to Str::orderedUuid() for keep order of database index.

[taylorotwell]

How are you defining a special unique ID that is being overwritten?

[jay-youngn]

How are you defining a special unique ID that is being overwritten?

@taylorotwell Thanks for your attention

My cases like this:

Part 1:
I have a function to generate unique IDs in ascending order.

<?php

namespace App\Supports;

use Str;

class UniqueID
{
    /**
     * Generates a string UID.
     */
    public static function generateString(): string
    {
        return str_replace('-', '', (string) Str::orderedUuid());
    }
}

Part 2:
And I assigned notification ID when an instance created.
(Because I want the primary key to be ordered in table notifications)

<?php

namespace App\Notifications;

use App\Enums\EntityAlias;
use App\Enums\InteractType;
use App\Models\User;
use App\Supports\UniqueID;
use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Notification;

class UserInteractsNotification extends Notification
{
    use Queueable;

    private EntityAlias $topic = EntityAlias::User;

    /**
     * Create a new notification instance.
     *
     * @return void
     */
    public function __construct(
        private InteractType $type,
        private User $fromUser,
    ) {
        $this->id = UniqueID::generateString();
    }

    /**
     * Get the notification's delivery channels.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function via($notifiable)
    {
        return ['database'];
    }

    // ...
}

Part 3:
If the UserInteractsNotification implements ShouldQueue, the earlier code in Illuminate\Notification\NotificationSender will always overwrite notification ID.

The important thing is... When queue driver is sync, overwrite will not happen, this is because there is such a piece of code in method NotificationSender::sendToNotifiable():

framework/src/Illuminate/Notifications/NotificationSender.php

Lines 138 to 146 in 3b8d805

	protected function sendToNotifiable($notifiable, $id, $notification, $channel)
	{
	if (! $notification->id) {
	$notification->id = $id;
	}
	if (! $this->shouldSendNotification($notifiable, $notification, $channel)) {
	return;
	}

When notification should queue, the method NotificationSender::queueNotification() will be called, and it does not have a determination of whether the ID exists or not.

So I added same code to line 194

framework/src/Illuminate/Notifications/NotificationSender.php

Lines 188 to 197 in 3b8d805

	foreach ($notifiables as $notifiable) {
	$notificationId = Str::uuid()->toString();
	foreach ((array) $original->via($notifiable) as $channel) {
	$notification = clone $original;
	if (! $notification->id) {
	$notification->id = $notificationId;
	}