[9.x] Handle undefined array key error - #42606
Merged
Merged
Conversation
Member
|
At least we're adding tests for all of this 👍 |
fulopattila122
added a commit
to artkonekt/appshell
that referenced
this pull request
Jun 3, 2022
This was referenced Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42605
Oh boy, the gift that keeps on giving. Looks like there's yet another edge case.
Summary
This PR fixes a regression when trying passing a model to the
routehelper for a route without route parameters.While I think this behavior is pretty weird, I guess it shouldn't break between minor versions.