Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Bind a Vite Null Object to the Container instead of a Closure #43040

Merged
merged 5 commits into from Jul 5, 2022
Merged

[9.x] Bind a Vite Null Object to the Container instead of a Closure #43040

merged 5 commits into from Jul 5, 2022

Conversation

mabdullahsari
Copy link
Contributor

Closes #43039

@taylorotwell @jessarcher
Update src/Illuminate/Foundation/Testing/Concerns/InteractsWithContai…
8e6bfb4 
…ner.php

Co-authored-by: Jess Archer <jess@jessarcher.com>
@taylorotwell
Copy link
Member

Tests are failing.

@taylorotwell taylorotwell marked this pull request as draft July 5, 2022 03:03
@jessarcher
Copy link
Member

Tests are failing.

Fixed. My bad - we still needed the __invoke() method as __call() alone doesn't make the class invokable.

@jessarcher jessarcher marked this pull request as ready for review July 5, 2022 03:48
@mabdullahsari
Copy link
Contributor Author

Tests are failing.

Fixed. My bad - we still needed the __invoke() method as __call() alone doesn't make the class invokable.

__call is indeed better for future additions. Thank you!

@taylorotwell taylorotwell merged commit 3aaf3b2 into laravel:9.x Jul 5, 2022
@mabdullahsari mabdullahsari deleted the patch-1 branch July 5, 2022 18:10
@mabdullahsari mabdullahsari mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessarcher jessarcher jessarcher left review comments

@timacdonald timacdonald timacdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestCase::withoutVite breaks React app during testing
4 participants
@mabdullahsari @taylorotwell @jessarcher @timacdonald