[9.x] Fix inconsistent content type when using ResponseSequence #43051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an inconsistency when using the
ResponseSequence::push
method.Summary
The
\Illuminate\Http\Client\Factory::response()
method sets the response’sContent-Type
header toapplication/json
and JSON encodes the response body if anarray
was passed as the$body
parameter.The
push
method of theResponseSequence
internally callsFactory::response
to create a newResponse
object. However, theResponseSequence::push
method also JSON encodes the request body if an array was passed before callingFactory::response
. This means that theContent-Type
header will not get set toapplication/json
in this case because$body
will be a string instead of an array.The fix is to simply not JSON serialize the
$body
variable insideResponseSequence::push
asFactory::response
already does that.