[9.x] Add whenCounted to JsonResource#43101
Merged
taylorotwell merged 7 commits intolaravel:9.xfrom Jul 14, 2022
stevebauman:feature-when-resource-counted
Merged
[9.x] Add whenCounted to JsonResource#43101taylorotwell merged 7 commits intolaravel:9.xfrom stevebauman:feature-when-resource-counted
whenCounted to JsonResource#43101taylorotwell merged 7 commits intolaravel:9.xfrom
stevebauman:feature-when-resource-counted
Conversation
Member
|
@stevebauman yeah, you can remove that |
Member
|
Can you PR docs for this @stevebauman ? |
Contributor
Author
|
Sure thing @taylorotwell 👍 |
This was referenced Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
whenCountedmethod to the JSON resource class giving us the ability to conditionally include attributes in a response when a relation count is set on the model viaPost::withCount('comments').This method acts nearly identically to
whenLoaded, with the exception that the retrieved count attribute value will be passed into the$valuecallback (if one is provided).I've also added a
hasAttributemethod to models to easily determine if an attribute exists inside of the models raw$attributesarray, so I didn't have to fetch all of the models attributes to determine if it exists:Example
Important
If you'd prefer not having the
hasAttributemethod added onto Eloquent models, let me know and I can remove it!Thanks for your time! ❤️