[9.x] feature: Str::inlineMarkdown() - #43126
Merged
taylorotwell merged 3 commits intoJul 11, 2022
Merged
Conversation
Str::inlineMarkdown()
Contributor
Author
|
@taylorotwell do you want a docs PR for this? or are you on it already |
Member
|
@danharrin feel free to send in a PR to the docs 👍 |
Contributor
Author
Member
|
@danharrin thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
Str::markdown()wraps all content in a block element<p>when converting.For certain layouts, this is inconvenient, as the markdown needs to be rendered inline instead.
Commonmark has a built-in
InlinesOnlyextension that we can use in aStr::inlineMarkdown()method.Additionally, I've added an
inlineMarkdown()method to the fluentStringableobject to maintain consistency.