[8.x] Fix transaction attempts counter for sqlsrv - #43176
Merged
taylorotwell merged 1 commit intoJul 14, 2022
Conversation
This brings back transactions attempts for sqlsrv driver
Member
|
When was it removed and why? |
Author
|
First introduced in #1883 (well not precisely, because at that time there wasn't $attempts implemented yet, but that was the initial version of this sqlsrv condition) , then during some bug fixing in f4588f8, for some reason the $attempts was omitted. For me it look like mistake, because there is no reason not to re-run transactions for (pdo) sqlsrv driver. This is interesting because during all that time nobody noticed this (I must admit that driver is not as popular, but still..) maybe @GrahamCampbell can help here? |
Collaborator
|
The commit you reference does not remove the parameter, but it's possible that not adding it at that point was a mistake. |
Collaborator
|
I think we could go-ahead and merge this, and see if anyone complains. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings back transactions attempts for sqlsrv driver