Skip to content

[9.x] Allows to install doctrine/dbal from model:show command#43288

Merged
taylorotwell merged 6 commits into
9.xfrom
feat/question-for-model-show-command
Jul 20, 2022
Merged

[9.x] Allows to install doctrine/dbal from model:show command#43288
taylorotwell merged 6 commits into
9.xfrom
feat/question-for-model-show-command

Conversation

@nunomaduro

@nunomaduro nunomaduro commented Jul 19, 2022

Copy link
Copy Markdown
Member

This pull request addresses #43284, by asking the user if he wants to install doctrine/dbal.

Screenshot 2022-07-19 at 17 20 42


Update: I've modified the message, and the "composer require", to install this package as regular dependency, and not as "dev" dependency.

@nunomaduro nunomaduro requested a review from taylorotwell July 19, 2022 16:30

@jessarcher jessarcher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this locally and it works perfectly! Nice one @nunomaduro! 🙌

Comment thread src/Illuminate/Foundation/Console/ShowModelCommand.php Outdated
@nunomaduro nunomaduro force-pushed the feat/question-for-model-show-command branch from c02887b to 82579fe Compare July 20, 2022 13:03
@nunomaduro nunomaduro force-pushed the feat/question-for-model-show-command branch from 82579fe to e698164 Compare July 20, 2022 13:08
@taylorotwell taylorotwell merged commit 6bcba99 into 9.x Jul 20, 2022
@taylorotwell taylorotwell deleted the feat/question-for-model-show-command branch July 20, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants