Repository navigation
[9.x] Add supportsTemporaryUrl to FilesystemAdapter - #43317
Merged
Merged
Conversation
Jasonej
marked this pull request as draft
July 20, 2022 14:18
Jasonej
marked this pull request as ready for review
July 20, 2022 14:48
Member
|
Hi! What is this fixing or doing? |
Contributor
Author
|
Hi, it's seeking to allow the following in situations where temp urls are preferred when supported, but are not required. $filesystem = Storage::disk($disk);
$url = $filesystem->supportsTemporaryUrl()
? $filesystem->temporaryUrl($path, $expiration)
: $filesystem->url($path);Currently, the temporaryUrlCallback is not exposed as it is protected, so to accomplish this behavior the options are to assume that no callback exists and rely on a |
Member
|
Renamed to |
salmanarshad321
pushed a commit
to salmanarshad321/framework
that referenced
this pull request
Sep 23, 2026
* add supportsTemporaryUrl to FilesystemAdapter * fix code style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
supportsTemporaryUrl()method toFilesystemAdapterthat checks if the adapter hasgetTemporaryUrlor atemporaryUrlCallback.