[9.x] Improves serve Artisan command#43375
Merged
Merged
Conversation
Contributor
|
@nunomaduro new implementation missing PHP version. Not sure it's really important, but may be useful in some edge cases. |
Member
Author
|
It's intentional. |
|
I'm getting an error serving from specific port and host. I think this can be resolved by putting an isset around the array of matches. This occures when running serve this way: and accessing the served site via |
Contributor
|
Rather than showing |
Member
Author
|
@ankurk91 It's not possible due PHP Built-in server limitations. |
Ken-vdE
pushed a commit
to Ken-vdE/framework
that referenced
this pull request
Aug 9, 2022
* Improves `serve` Artisan command * Handles better edge cases * Removes assets requests, and displays unexpected output as "warn" * Simplifies command and handles assets * Better captures * formatting Co-authored-by: Taylor Otwell <taylor@laravel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves Laravel's
serveartisan command. Here is the difference:So, the output got improved. The "time" is the only information highlighted, as is the only thing that actually changes. And we got to see a "rounded" duration of the request.
Note that, because we are using PHP's built-in server using a file such as "server.php", we don't have information regarding the Method, Uri, Response Code, etc.
In addition, unexpected output such as port already in use, or
.envgot changed, is displayed this way: