Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Gracefully fail when unable to locate expected binary on the system for artisan docs command #43521

Merged
merged 1 commit into from Aug 3, 2022

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Aug 3, 2022

The expected binaries may not actually be present on the system. This is generally going to be the case on linux systems.

This PR ensures we detect the binary before attempting to call it.

We now suggest opening the URL manually (which is now in the command line output) or creating a custom opener.

Screen Shot 2022-08-03 at 11 05 52 am

@timacdonald timacdonald marked this pull request as draft Aug 3, 2022
@timacdonald timacdonald force-pushed the missing-docs-opener branch 2 times, most recently from 039bb31 to 1bc16f2 Compare Aug 3, 2022
@timacdonald timacdonald marked this pull request as ready for review Aug 3, 2022
@taylorotwell taylorotwell merged commit b67f4af into laravel:9.x Aug 3, 2022
16 checks passed
@timacdonald timacdonald deleted the missing-docs-opener branch Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants