[9.x] Gracefully fail when unable to locate expected binary on the system for artisan docs command - #43521
Merged
Merged
Conversation
timacdonald
force-pushed
the
missing-docs-opener
branch
from
August 3, 2022 01:04
7109401 to
02382ee
Compare
timacdonald
marked this pull request as draft
August 3, 2022 01:04
timacdonald
force-pushed
the
missing-docs-opener
branch
2 times, most recently
from
August 3, 2022 01:08
039bb31 to
1bc16f2
Compare
timacdonald
force-pushed
the
missing-docs-opener
branch
from
August 3, 2022 01:10
1bc16f2 to
91824d5
Compare
timacdonald
marked this pull request as ready for review
August 3, 2022 01:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expected binaries may not actually be present on the system. This is generally going to be the case on linux systems.
This PR ensures we detect the binary before attempting to call it.
We now suggest opening the URL manually (which is now in the command line output) or creating a custom opener.