Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update RouteRegistrar.php" #43523

Merged
merged 1 commit into from Aug 3, 2022

Conversation

Ken-vdE
Copy link
Contributor

@Ken-vdE Ken-vdE commented Aug 3, 2022

Reverts #43509

@taylorotwell This does not work and should be reverted. It seems the RouteRegistrar::__call() method does not pass the parameters correctly. The passed array is omitted there. I don't see a clear solution other then adding another if exception for the 'whereIn' just like the if ($method === 'middleware') { statement in that __call method.
Do you think that would be an acceptable solution?

@taylorotwell taylorotwell merged commit 87cdcc9 into laravel:9.x Aug 3, 2022
17 checks passed
@taylorotwell
Copy link
Member

taylorotwell commented Aug 3, 2022

If there is a better solution feel free to PR.

Ken-vdE added a commit to Ken-vdE/framework that referenced this pull request Aug 9, 2022
@ollieread
Copy link
Contributor

ollieread commented Aug 16, 2022

@Ken-vdE did you ever figure out a solution for this? I'm happy to take a look.

@Ken-vdE
Copy link
Contributor Author

Ken-vdE commented Aug 16, 2022

@ollieread I haven't gotten around to it yet. Have at it ;)

@ollieread
Copy link
Contributor

ollieread commented Aug 16, 2022

@ollieread I haven't gotten around to it yet. Have at it ;)

Have added a new PR addressing this @Ken-vdE #43731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants