Skip to content

[9.x] Improve output for some Artisan commands - #43547

Merged
taylorotwell merged 3 commits into
laravel:9.xfrom
sarukomine:improve-command-ui
Aug 4, 2022
Merged

[9.x] Improve output for some Artisan commands#43547
taylorotwell merged 3 commits into
laravel:9.xfrom
sarukomine:improve-command-ui

Conversation

@sarukomine

Copy link
Copy Markdown
Contributor

This PR is for #43543, to add the additional space after the output.

Before

Screenshot 2022-08-04 at 4 30 11 PM

After

Screenshot 2022-08-04 at 4 35 58 PM

Screenshot 2022-08-04 at 4 36 07 PM

@nunomaduro nunomaduro changed the title Improve output for some Artisan commands [9.x] Improve output for some Artisan commands Aug 4, 2022
@nunomaduro

Copy link
Copy Markdown
Member

Remember this being an issue, when running different artisan commands, such as "migrate:fresh", "migrate:refresh", using different options such as "--seed", etc. Do you mind of testing all the possible combinations together?

@sarukomine

Copy link
Copy Markdown
Contributor Author

Remember this being an issue, when running different artisan commands, such as "migrate:fresh", "migrate:refresh", using different options such as "--seed", etc. Do you mind of testing all the possible combinations together?

@nunomaduro sure

@driesvints

Copy link
Copy Markdown
Member

Tests need to be fixed here as well.

@driesvints
driesvints marked this pull request as draft August 4, 2022 08:55
@sarukomine

Copy link
Copy Markdown
Contributor Author

@nunomaduro I have improved migrate:fresh command, and I checked other commands look good, please let me know if I still missed some~

@driesvints Fixed tests, now passed all tests

@driesvints
driesvints marked this pull request as ready for review August 4, 2022 10:27
@taylorotwell
taylorotwell merged commit dfeac8c into laravel:9.x Aug 4, 2022
@sarukomine
sarukomine deleted the improve-command-ui branch August 5, 2022 01:13
Ken-vdE pushed a commit to Ken-vdE/framework that referenced this pull request Aug 9, 2022
* Improve output for some Artisan commands

* Improve output for migrate:fresh command

* Fix tests

Co-authored-by: Alvin Lau <alvinlau@fimmick.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants