Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Improve output for some Artisan commands #43547

Merged
merged 3 commits into from Aug 4, 2022

Conversation

sarukomine
Copy link
Contributor

@sarukomine sarukomine commented Aug 4, 2022

This PR is for #43543, to add the additional space after the output.

Before

Screenshot 2022-08-04 at 4 30 11 PM

After

Screenshot 2022-08-04 at 4 35 58 PM

Screenshot 2022-08-04 at 4 36 07 PM

@nunomaduro nunomaduro changed the title Improve output for some Artisan commands [9.x] Improve output for some Artisan commands Aug 4, 2022
@nunomaduro
Copy link
Member

nunomaduro commented Aug 4, 2022

Remember this being an issue, when running different artisan commands, such as "migrate:fresh", "migrate:refresh", using different options such as "--seed", etc. Do you mind of testing all the possible combinations together?

@sarukomine
Copy link
Contributor Author

sarukomine commented Aug 4, 2022

Remember this being an issue, when running different artisan commands, such as "migrate:fresh", "migrate:refresh", using different options such as "--seed", etc. Do you mind of testing all the possible combinations together?

@nunomaduro sure

@driesvints
Copy link
Member

driesvints commented Aug 4, 2022

Tests need to be fixed here as well.

@driesvints driesvints marked this pull request as draft Aug 4, 2022
@sarukomine
Copy link
Contributor Author

sarukomine commented Aug 4, 2022

@nunomaduro I have improved migrate:fresh command, and I checked other commands look good, please let me know if I still missed some~

@driesvints Fixed tests, now passed all tests

@driesvints driesvints marked this pull request as ready for review Aug 4, 2022
@taylorotwell taylorotwell merged commit dfeac8c into laravel:9.x Aug 4, 2022
16 checks passed
@sarukomine sarukomine deleted the improve-command-ui branch Aug 5, 2022
Ken-vdE pushed a commit to Ken-vdE/framework that referenced this pull request Aug 9, 2022
* Improve output for some Artisan commands

* Improve output for migrate:fresh command

* Fix tests

Co-authored-by: Alvin Lau <alvinlau@fimmick.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants