Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the issue of running docs command on windows #43566

Merged
merged 2 commits into from Aug 5, 2022

Conversation

mahmoudmohamedramadan
Copy link
Contributor

@mahmoudmohamedramadan mahmoudmohamedramadan commented Aug 5, 2022

The old version of that charming command was not working on Windows (my OS type), it was opening CMD only not the browser as it should have done so, I tried to change escapeshellargs to escapeshellcmd and FINALLY, it works perfectly 馃帀

In the old version
was using start ONLY on my OS so, the command was run perfectly.

In the new version
When @timacdonald introduces a new PR, the command is getting to use a full path for an executable file like C:\Program Files\Git\usr\bin\start.COM but, this command does not work perfectly on my OS so, I introduce this PR to solve The command "C:\Program Files\Git\usr\bin\start.COM https://laravel.com/docs/9.x/views" failed. I see it's IMPORTANT to check about the executable file as he has done but, then we can use the keywords according to OS type like open, start with escapeshellcmd function to make sure that the command will work perfectly.

@taylorotwell taylorotwell merged commit e682c7a into laravel:9.x Aug 5, 2022
15 of 16 checks passed
@timacdonald
Copy link
Member

timacdonald commented Aug 8, 2022

Thank for looking at this @mahmoudmohamedramadan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants