Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] This PR improves windows support and adds WSL support for the artisan docs command #43585

Merged
merged 1 commit into from Aug 8, 2022

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Aug 8, 2022

This PR adds WSL support by checking to see if the wslview binary is available on Linux systems (which WSL is). This is a helper binary that allows us to open URLs in the browser from WSL.

It also improves Windows support as start does not seem to be an executable that Symfony executable helper is able to detect.

It seems common to just forget about checking and open URLs with start in Windows. I'm assuming this is because start is a fundamental piece of Windows that "is just available".

You can see a similar approach take in Composer

Test IRL against:

  • MacOS
  • Linux
  • Windows
  • Windows w/ WSL

Thanks @jessarcher and @aschmelyun for testing this on their local machines ❤️

@timacdonald timacdonald marked this pull request as draft Aug 8, 2022
@timacdonald timacdonald marked this pull request as ready for review Aug 8, 2022
@taylorotwell taylorotwell merged commit 50f5a91 into laravel:9.x Aug 8, 2022
17 checks passed
@timacdonald timacdonald deleted the open-windows branch Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants