[9.x] This PR improves windows support and adds WSL support for the artisan docs command - #43585
Merged
Merged
Conversation
timacdonald
marked this pull request as draft
August 8, 2022 04:35
timacdonald
marked this pull request as ready for review
August 8, 2022 07:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds WSL support by checking to see if the
wslviewbinary is available on Linux systems (which WSL is). This is a helper binary that allows us to open URLs in the browser from WSL.It also improves Windows support as
startdoes not seem to be an executable that Symfony executable helper is able to detect.It seems common to just forget about checking and open URLs with
startin Windows. I'm assuming this is becausestartis a fundamental piece of Windows that "is just available".You can see a similar approach take in Composer
Test IRL against:
Thanks @jessarcher and @aschmelyun for testing this on their local machines ❤️