Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Fixes output when running db:seed or using --seed in migrate commands #43593

Merged
merged 3 commits into from Aug 8, 2022

Conversation

nunomaduro
Copy link
Member

@nunomaduro nunomaduro commented Aug 8, 2022

Fixes #43515.

Recently, we have introduced a fresh new output for Artisan, and the db:seed command:

1

While this output is insanely pretty it does not play well when the user uses the $this->command->info, or similar methods, to print output in the middle of the task:

2

To address this issue, this pull request adopts a different approach that supports output being printed in the middle of a task:

Without output With output

@nunomaduro nunomaduro requested a review from taylorotwell Aug 8, 2022
@taylorotwell taylorotwell merged commit c717a1d into 9.x Aug 8, 2022
33 checks passed
@taylorotwell taylorotwell deleted the fix/output-on-seeds branch Aug 8, 2022
Ken-vdE pushed a commit to Ken-vdE/framework that referenced this pull request Aug 9, 2022
…e commands (laravel#43593)

* Fixes output on seeds

* Apply fixes from StyleCI

* Fixes tests

Co-authored-by: StyleCI Bot <bot@styleci.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants