Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.x] Make Config repository macroable #43598

Merged
merged 1 commit into from Aug 8, 2022

Conversation

PHLAK
Copy link
Contributor

@PHLAK PHLAK commented Aug 8, 2022

Make the Config repository macroable so users can extend it in their own apps.

Reasoning: Since #43520 was closed without merging I was hoping to implement Config::collect() via a macro, however the Config repository is not currently macroable.

@driesvints driesvints changed the title Make Config facade macroable Make Config repository macroable Aug 8, 2022
@PHLAK PHLAK changed the title Make Config repository macroable [9.x] Make Config facade macroable Aug 8, 2022
@driesvints
Copy link
Member

driesvints commented Aug 8, 2022

Renamed this PR title to what it actually does.

@driesvints driesvints changed the title [9.x] Make Config facade macroable [9.x] Make Config repository macroable Aug 8, 2022
@taylorotwell taylorotwell merged commit 45ccf22 into laravel:9.x Aug 8, 2022
16 checks passed
Ken-vdE pushed a commit to Ken-vdE/framework that referenced this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants