Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue worker daemon should also listen for SIGQUIT #43607

Merged
merged 1 commit into from Aug 9, 2022

Conversation

LachlanArthur
Copy link
Contributor

@LachlanArthur LachlanArthur commented Aug 9, 2022

This PR adds a listener for the SIGQUIT signal.

The queue worker currently listens for SIGTERM to gracefully exit.

However, the official Docker PHP-FPM images (and most images based on them) have the stop signal set to SIGQUIT instead:

$ docker inspect php:8.1-fpm | jq '.[0].ContainerConfig.StopSignal'
> "SIGQUIT"

This means that when Docker executes a stop/restart/etc command, the SIGQUIT signal sent by Docker is not detected. The queue worker continues to run jobs up until it's SIGKILLed by Docker - potentially halfway through a job.

@taylorotwell taylorotwell merged commit 14cd42d into laravel:9.x Aug 9, 2022
17 checks passed
chu121su12 pushed a commit to chu121su12/framework that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants