Ensure correct 'integrity' value is used for css assets - #43714
Merged
Conversation
julesjanssen
marked this pull request as ready for review
August 16, 2022 00:00
timacdonald
approved these changes
Aug 16, 2022
timacdonald
left a comment
timacdonald
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing this one. Tested and confirmed.
jessarcher
approved these changes
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like with a css resource that is a dependency of an import, a directly imported css file should also use its own manifest record to make sure the correct integrity value is applied.
Before this change, the
<linkwould use the integrity key of the JS asset.