Adding support for non-backed enums#43728
Merged
Merged
Conversation
Contributor
|
please add tests if possible, what happen if someone modify your code later |
|
Should the non-backed enums also be implemented in the |
Contributor
Author
This is a very good point! |
Contributor
Author
|
@laravel there's a valid point raised by @johanmolen, will fix this ASAP |
|
@ollieread awesome, if you need help let me know. |
|
@ollieread my quick fix for now (line 310): |
Contributor
Author
|
Added a fix in #43842 @johanmolen |
|
@ollieread Awesome 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for non-backed enums when casting eloquent attributes. It works based on the fact that enum cases are glorified constants, so the
constant()method will work for retrieving.It also updates the
$valueparam type forIlluminate\Database\Eloquent\Concerns\HasAttributes::setEnumCastableAttributefrom\BackedEnumto\UnitEnum|string|int. It's worth noting that the original version should have technically been\BackedEnum|string|intbecause there are code paths for handling when it isn't an instance.