[9.x] Adjust forever time for cookies#43806
Merged
Merged
Conversation
Contributor
|
Just changing a comment is not enough to change the value 😅
|
Member
Author
|
Done thanks. I left the |
bogdankharchenko
added a commit
to bogdankharchenko/framework
that referenced
this pull request
Sep 6, 2022
This PR laravel#43806 changed the max cookie lifetime of the "forever" cookie - these two values are now misaligned.
taylorotwell
pushed a commit
to illuminate/auth
that referenced
this pull request
Sep 6, 2022
…4026) * [8.x] Align Remember Me Cookie Duration with CookieJar expiration This PR laravel/framework#43806 changed the max cookie lifetime of the "forever" cookie - these two values are now misaligned. * Update Test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maximum amount of days for an Expiration date of a cookie is apparently limited to 400 days.
See https://httpwg.org/http-extensions/draft-ietf-httpbis-rfc6265bis.html#section-4.1.2.1
Also #43804