[9.x] Make Vite::hotFile() public#43875
Merged
Merged
Conversation
Jubeki
changed the title
Vite::hotFile() public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
I often encounter the Problem while developing that I run into an error and then I need to manually reload the page after correcting the error. Using ViteJS it is already possible to reload the page automatically on file save and I would love it, if there is a way for auto reloading the error page to check if the code is running correctly.
For that I added the ability to add custom HTML to the error page in spatie/ignition#161
There is already a followup PR for adding the Vite Reload Script to the Error Page Head in spatie/laravel-ignition#110
While doing the PR I saw, that the
hotFilemethod is protected, which is needed for detecting the correct file path. (Otherwise only a fallback to the public path hot-file is possible)This PR makes the
hotFilemethod public.