[9.x] Allow registering instances of commands - #43986
Merged
Merged
Conversation
nunomaduro
requested changes
Sep 3, 2022
| return null; | ||
| } | ||
|
|
||
| if ($command instanceof Command) { |
Member
There was a problem hiding this comment.
@freekmurze Can adjust the PHP Annotations of the resolve method, and add a test on this?
Contributor
Author
There was a problem hiding this comment.
Annotation adjusted. Like said in the PR description, I didn't find any meaningful tests for this method to build on.
nunomaduro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, you can only pass class names (or an array of class names) to
resolveCommands. With the change in this PR, you can also pass instances of commands.This change is needed power this upcoming feature in laravel-package-tools. Under the hood this works by instantiating a command, dynamically setting its signature, and registering the instantiated command (here, and here).
I didn't find any relevant tests around this, so I added none. Happy to add a test if you point me in the right direction. I did manually test it in a fresh Laravel app though.