Skip to content

[9.x] Fixes providesTemporaryUrls on AwsS3V3Adapter#44009

Merged
taylorotwell merged 4 commits intolaravel:9.xfrom
pyrou:patch-1
Sep 5, 2022
Merged

[9.x] Fixes providesTemporaryUrls on AwsS3V3Adapter#44009
taylorotwell merged 4 commits intolaravel:9.xfrom
pyrou:patch-1

Conversation

@pyrou
Copy link
Contributor

@pyrou pyrou commented Sep 5, 2022

When using providesTemporaryUrls introduced in #43317 on a s3 disk, providesTemporaryUrls() method always returns false

>>> Storage::disk('s3')->providesTemporaryUrls()
=> false // expected true

This is because providesTemporaryUrls implementation relies on adapter getTemporaryUrl method existence which doesn't exists on League\Flysystem\AwsS3V3\AwsS3V3Adapter

Since Illuminate\Filesystem\AwsS3V3Adapter overrides temporaryUrl, and doesn't rely on adapter, we can also safely override providesTemporaryUrls method to always return true.

@taylorotwell taylorotwell merged commit 5de463e into laravel:9.x Sep 5, 2022
@pyrou pyrou deleted the patch-1 branch September 6, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants