Repository navigation
[9.x] Add Vite asset path generation method - #44037
Merged
Merged
Conversation
Member
|
Just note that the I'd recommend just setting the |
Just FYI, a delta between the asset URL and the physical folder can be weird, annoying and confusing. But it's the whole point of this (and similar optional customisations) in webpack / mix. For example shared hosting often has weird symlinks and rules around public folders. These types of customisations help the build pipeline for those developers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a method to the
Viteclass so the the way the asset URLs are generated can be separated from the main class.This would make it so Teams/Projects that have their own way of loading assets can extend the functionality of the
Viteclass and add their own method of loading assets.This would ease the path of migrations from Laravel-Mix to Vite for those teams.
The
assetPath()method has the same signature as the globalasset()helper