[9.x] Added scoped filesystem driver - #44105
Merged
taylorotwell merged 5 commits intoSep 13, 2022
Merged
Conversation
|
@frankdejonge Hi, I cannot get the correct URL for the scoped drivers with $storage->url(). The prefix is missing as it's not implemented in the url function in class FilesystemAdapter. |
|
I have created an issue with details. |
This was referenced Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Often, files are placed on a single filesystem (like S3) but at different paths. This base path needs to be kept in sync all across the codebase. The scoped driver makes it easy to re-use disk configurations, and decorated the internal adapter.
Consider the following situation, when I have an existing
s3disk:Using the new
scopeddriver, I can create a version of the existings3driver with a deeper base path:Possible optimisation, since this is a decorated adapter, we could re-use the inner adapter. I didn't find an elegant way to do so, but I'm open to suggestions.