[9.x] Improve Blade compilation exception messages - #44134
Merged
taylorotwell merged 6 commits intoSep 15, 2022
Conversation
|
Because the regex quantifier after "as" was changed from * to +, if the foreach statement is multiline, this now throws an error: Should this be considered? |
Contributor
Author
I wasnt considering. I will submit a PR fixing it EDIT I submitted a PR fixing this issue: |
This was referenced Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when we write a
@foreachor@forelsethe wrong way, the exception message is not descriptive. e.g:Code:
Exception:

The main objective of this PR is to improve this message:

In an actual situation, it occurred for a beginner developer to take hours to discover the problem since the stacktrace also doesn't make it easy to debug issues in rendering views.