[9.x] Share WithoutOverlapping key across jobs#44227
Merged
taylorotwell merged 2 commits intoSep 21, 2022
Merged
Conversation
|
Hah, I ran into the same constraint earlier last week and wanted to contribute but you beat me to it. 😄 |
Member
Author
|
No troubles! Glad to hear it will be useful :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows
WithoutOverlappingto apply across different job classes. Currently this feature only allows without overlapping to be applied to instances of a single class.These two jobs will now not overlap even though they are different classes. They both utilise the same lock key (assuming the provider is the same) `"provider-status:{providerName}".
Thanks @andrewbroberg for raising and chatting to me about this.
Documentation PR: laravel/docs#8240