[9.x] Add Ignore Case of Str::contains and Str::containsAll to Stringable contains and containsAll#44369
Merged
taylorotwell merged 2 commits intolaravel:9.xfrom Sep 29, 2022
byt3sage:feature/add-case-sensitivity-to-fluent-string-contains
Merged
[9.x] Add Ignore Case of Str::contains and Str::containsAll to Stringable contains and containsAll#44369taylorotwell merged 2 commits intolaravel:9.xfrom byt3sage:feature/add-case-sensitivity-to-fluent-string-contains
taylorotwell merged 2 commits intolaravel:9.xfrom
byt3sage:feature/add-case-sensitivity-to-fluent-string-contains
Conversation
byt3sage
changed the title
byt3sage
deleted the
feature/add-case-sensitivity-to-fluent-string-contains
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is here to resolve a little gremlin I found when using Fluent Strings. I wanted to do
->contains()and I needed it to ignore case. It turns out this isn't possible with the Stringable class. I've added in the ability to pass a boolean to StringablecontainsandcontainsAlllike how StrcontainsandcontainsAllworks. I've also updated the pre-existing tests to test that ignore case works.This doesn't break any existing implementations of these functions because it is an optional parameter placed last.
Now I did think about adding this to
whenContainsandwhenContainsAll- if you feel this would be of benefit also within this PR then let me know and I'll get that bashed in.I'm aware this is my first PR to the framework, so any feedback would be greatly appreciated.