Skip to content

[9.x] Fix Precognition headers for Symfony responses - #44424

Merged
taylorotwell merged 2 commits into
laravel:9.xfrom
timacdonald:precognition-headers
Oct 3, 2022
Merged

taylorotwell merged 2 commits into
laravel:9.xfrom
timacdonald:precognition-headers

Conversation

@timacdonald

Copy link
Copy Markdown
Member

The $response->header() function is only available on Laravel responses. This PR fixes usage with Symfony responses, such as BinaryFileResponse.

@bert-w

bert-w commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

But the docblock says @param \Illuminate\Http\Request $request? Is it intended to somehow use this middleware with Symfony requests?

@driesvints

Copy link
Copy Markdown
Member

@bert-w a symfony response can still be sent out instead of a Illuminate http response.

@taylorotwell
taylorotwell merged commit 23e8dd8 into laravel:9.x Oct 3, 2022
@timacdonald
timacdonald deleted the precognition-headers branch January 10, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants