[9.x] Fix relative links for regular files#44519
Merged
taylorotwell merged 1 commit intolaravel:9.xfrom Oct 13, 2022
luchaos:relative-links
Merged
[9.x] Fix relative links for regular files#44519taylorotwell merged 1 commit intolaravel:9.xfrom luchaos:relative-links
taylorotwell merged 1 commit intolaravel:9.xfrom
luchaos:relative-links
Conversation
This was referenced Oct 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel's
storage:link --relativecommand breaks when configuring paths to regular files.How to reproduce
Add
symfony/filesystemto support relative links:Add link to regular file in
config/filesystems.php:Run storage link command with relative option:
Results in...
... because the relative path now has a trailing slash:
../README.md/.This PR mitigates a bug in Symfony's filesystem component which dates back all the way to 2012, introduced in Laravel 8.x.
I wouldn't expect this bug to be fixed in Symfony itself anytime soon given its history. The fix on Laravel's framework level is simple enough without breaking any existing behaviour (I don't think this particular case ever worked in the first place).
This could be backported to 8.x easily if desired; adhering to the support policy.