[9.x] Add dontIncludeSource to CliDumper and HtmlDumper#44623
Merged
Conversation
preventDumpingSource to CliDumper and HtmlDumperdontIncludeSource to CliDumper and HtmlDumper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a
preventDumpingSourcestatic method toIlluminate\Foundation\Concerns\ResolvesDumpSource, effectively affectingIlluminate\Foundation\Console\CliDumperandIlluminate\Foundation\Http\HtmlDumper.When called, this method prevents the
dumpandddfunctions from displaying a comment with the source of the dump.While the idea is very nice, in practice it has made dumps cumbersome to read and understand for me. Here is an example:
The functionality can already be disabled by calling
HtmlDumper::resolveDumpSourceUsing(fn () => null), but I didn't found out until I dove into the code. The point of this pull request is to allow preventing the dump resolution in a cleaner and more accessible way: