Skip to content

[9.x] Revert PR #44613#44672

Merged
taylorotwell merged 1 commit into
laravel:9.xfrom
mtawil:patch-5
Oct 20, 2022
Merged

[9.x] Revert PR #44613#44672
taylorotwell merged 1 commit into
laravel:9.xfrom
mtawil:patch-5

Conversation

@mtawil

@mtawil mtawil commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

The previous PR #44613 is a breaking change. Changing the route parameter name is unrelated to the ORM!

My registration page is now crashed because of this change, and I've to override the fortify route file and change the {id} to {user_id}, so it will fit this PR! That doesn't make sense.

Here is my comment: #44613 (comment)

@mtawil mtawil changed the title Revert PR #44613 [9.x] Revert PR #44613 Oct 20, 2022
@taylorotwell taylorotwell merged commit 5b20be4 into laravel:9.x Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants