[9.x] Prevents booting of providers when running env:encrypt#44758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves laravel/telescope#1262
When running
env:encryptwith the--envoption, the command is run as if in that environment and is booted using the associated environment file.For example,
php artisan env:encrypt --env=staging" runs the command using the environment variables from.env.staging`.This can cause an issue if a service provider relies on a resource which is only accessible in that environment.
In the case of the issue above, it was Telescope attempting to register the Redis watcher for a cluster only accessible in the staging envrionment. Trying to run the command locally results in an exception being thrown.
To resolve the issue, I've prevented providers from booting when running the
env:encryptusing the same approach as #44654