[9.x] Add ability to set middleware based on notifiable instance and channel#44767
Merged
taylorotwell merged 3 commits intolaravel:9.xfrom Oct 28, 2022
AndrewMonty:notification-middleware-context
Merged
[9.x] Add ability to set middleware based on notifiable instance and channel#44767taylorotwell merged 3 commits intolaravel:9.xfrom AndrewMonty:notification-middleware-context
taylorotwell merged 3 commits intolaravel:9.xfrom
AndrewMonty:notification-middleware-context
Conversation
This was referenced Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussed in #44766
I want to apply middleware to my queueable notifications, but only for specific channels and/or users. For example; no middleware for database notifications, but apply a rate limiter to email and sms notifications - unless the notifiable is an admin.
My suggestion is to pass
$notifiableand$channelto themiddleware()method on queuable notifications, similar to how withDelay works.Now I can change my middleware stack depending on the notifiable and channel of each job instance.