[9.x] Decouple database component from console component - #44798
Merged
taylorotwell merged 1 commit intoNov 1, 2022
Conversation
vdauchy
force-pushed
the
decoupling-database-from-console
branch
from
October 31, 2022 21:54
1f1012a to
a2d828d
Compare
vdauchy
marked this pull request as ready for review
October 31, 2022 22:01
GrahamCampbell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'm using https://github.com/illuminate/database as standalone dependency and since @nunomaduro improved the console output this component have a hard dependency toward https://github.com/illuminate/console (It is impossible to run migrations without it).
There was already some work to handle the absence of output but it does not handle the absence of the
View\Components: illuminate/database@8e5c9a3This PR tryies to decouple furthermore by checking if the
View\Componentsclasses exist... Else the callbacks passed as args are executed (this is mandatory as some of them do critical work).Thanks for your work :-)