[9.x] Inherit crossorigin attributes while preloading#44800
Merged
taylorotwell merged 3 commits intolaravel:9.xfrom Nov 1, 2022
Merged
[9.x] Inherit crossorigin attributes while preloading#44800taylorotwell merged 3 commits intolaravel:9.xfrom
taylorotwell merged 3 commits intolaravel:9.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"CORS"...the thing every developer wants to wake up and hear about 💆♂️
This PR improves upon the preloading functionality with Vite by having preload tags inherit the
crossoriginattribute from their standard script / link tag counterpart.If an app is adding a crossorigin attribute...
That results in the following HTML...
The trouble is that the two tags must have matching
crossorigintags, otherwise a double fetch is performed. To manually solve this, you can specify the crossorigin tag for preload tags...After this PR, there is no need to manually specify the preload tag attribute for
crossorigin, as it will be inherited from theuseScriptTagAttributessetup.This means that the following setup...
results in the following HTML...
where both tags have the same
crossoriginattribute. A develop may still override the preload tag attribute for thecrossoriginattribute, however I can't see any reason why you would ever want to do this.