Skip to content

[9.x] Update database version check for lock popping for PlanetScale - #44925

Merged
taylorotwell merged 2 commits into
laravel:9.xfrom
narciero:patch-1
Nov 14, 2022
Merged

taylorotwell merged 2 commits into
laravel:9.xfrom
narciero:patch-1

Conversation

@narciero

Copy link
Copy Markdown
Contributor

PlanetScale (Vitess) does not support SKIP LOCKED.

This issue was addressed previously in #44027 however PlanetScale seems to have changed their version string suffix from -vitess to -PlanetScale.

> DB::connection()->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION)
= "8.0.23-PlanetScale"

Comment thread src/Illuminate/Queue/DatabaseQueue.php Outdated
@narciero
narciero requested a review from fragkp November 13, 2022 16:46

@fragkp fragkp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@taylorotwell
taylorotwell merged commit 5f134c7 into laravel:9.x Nov 14, 2022
@narciero
narciero deleted the patch-1 branch November 14, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants