[9.x] Add assertRedirectToRoute to TestResponse#44926
Merged
Merged
Conversation
assertRedirectToRoute to TestResponse
Contributor
|
The See this test case for PoC: |
Contributor
Author
|
I'll push new code in a few min. thanks @gms8994 for catching this, I added your test to the code to make sure everything is working as it should. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Illuminate\Testing\TestResponsehas several helpers to assert the response has a redirect of various types. There isassertRedirect(string $uri = null),assertRedirectContains(string $uri), andassertRedirectToSignedRoute(string $name = null, array $parameters = []).This PR add a missing assertion
assertRedirectToRoute, which in theory does not differ much fromassertRedirectToSignedRoute.Used as the following:
and in case of passing parameters we use it as the following: