Skip to content

[9.x] Add some class rules in class Rule#44998

Merged
taylorotwell merged 4 commits intolaravel:9.xfrom
michaelnabil230:add-rule
Nov 18, 2022
Merged

[9.x] Add some class rules in class Rule#44998
taylorotwell merged 4 commits intolaravel:9.xfrom
michaelnabil230:add-rule

Conversation

@michaelnabil230
Copy link
Contributor

@michaelnabil230 michaelnabil230 commented Nov 17, 2022

It is the best way to call these functions password and imageFile and file, enum.

And don't call in Controller or FormValidation all namespace

Before PR:

use Illuminate\Http\Request;
use Illuminate\Validation\Rule;
use Illuminate\Validation\Rules\Password;
use Illuminate\Validation\Rules\File;
use Illuminate\Validation\Rules\Enum;

class WelcomeController
{
    public function store(Request $request)
    {
        $request->validate([
            'password' => Password::default(),
            'image' => File::default(),
            'status' => new Enum(StatusEnum::class),
            'name' => Rule::requiredIf(function () {
                return true;
            })
        ]);

        // 
    }
}

After PR:

use Illuminate\Http\Request;
use Illuminate\Validation\Rule;

class WelcomeController
{
    public function store(Request $request)
    {
        $request->validate([
            'password' => Password::default(),
            'image' => Rule::file()->default(),
            'status' => Rule::enum(StatusEnum::class),
            'name' => Rule::requiredIf(function () {
                return true;
            })
        ]);

        // 
    }
}

@taylorotwell taylorotwell merged commit 189cec5 into laravel:9.x Nov 18, 2022
@taylorotwell
Copy link
Member

Removed the password one. The rest seems fine.

@michaelnabil230 michaelnabil230 deleted the add-rule branch November 23, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants